Re: GUC for temporarily disabling event triggers

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: GUC for temporarily disabling event triggers
Date: 2023-09-06 20:23:55
Message-ID: F77693DD-C7E4-453F-A9DF-6ACB43DDB974@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 6 Sep 2023, at 16:22, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 6, 2023 at 4:50 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

>> Fair enough, how about disable_event_trigger instead as per the attached?
>
> I usually prefer to give things a positive sense, talking about
> whether things are enabled rather than disabled. I'd do event_triggers
> = off | on, like we have for row_security. YMMV, though.

Fair enough, I don't have strong opinions and I do agree that making this work
like row_security is a good thing for consistency. Done in the attached.

--
Daniel Gustafsson

Attachment Content-Type Size
v8-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch application/octet-stream 8.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2023-09-06 21:21:22 Re: Eliminate redundant tuple visibility check in vacuum
Previous Message Robert Haas 2023-09-06 20:21:31 Re: Eager page freeze criteria clarification