| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Luis Carril <luis(dot)carril(at)swarm64(dot)com> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Option to dump foreign data in pg_dump |
| Date: | 2019-11-12 15:38:36 |
| Message-ID: | F6E4F71A-4471-46FA-AA4F-94B53B7B8C04@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Nov 2019, at 15:21, Luis Carril <luis(dot)carril(at)swarm64(dot)com> wrote:
>
>> The nitpicks have been addressed. However, it seems that the new file
>> containing the test FDW seems missing from the new version of the patch. Did
>> you forget to git add the file?
> Yes, I forgot, thanks for noticing. New patch attached again.
The patch applies, compiles and tests clean. The debate whether we want to
allow dumping of foreign data at all will continue but I am marking the patch
as ready for committer as I believe it is ready for input on that level.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2019-11-12 15:53:07 | [PATCH][BUG FIX] Potential uninitialized vars used. |
| Previous Message | Daniel Gustafsson | 2019-11-12 15:25:06 | Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions? |