| From: | Alik Khilazhev <a(dot)khilazhev(at)postgrespro(dot)ru> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [WIP] Zipfian distribution in pgbench |
| Date: | 2017-08-22 20:09:38 |
| Message-ID: | F653D130-D241-48BB-8B14-988780176F7C@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, Fabien
I am attaching patch v7.
> Yes, I agree. a >= 10000 does not make much sense... If you want uniform you should use random(), not call random_zipfian with a = 10000. Basically it suggests that too large values of "a" should be rejected. Not sure where to put the limit, though.
I set upper bound for parameter to be equal to 1000.
>
> Yes, as a general principle I think that the documentation should reflect the implementation.
Documentation have been updated, I have removed algorithms descriptions and put references to them there.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-zipf-07v.patch | application/octet-stream | 9.4 KB |
| unknown_filename | text/plain | 119 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-08-22 23:29:04 | Blessed TupleDescs and constraints |
| Previous Message | Christoph Berg | 2017-08-22 19:40:33 | Re: initdb failure on Debian sid/mips64el in EventTriggerEndCompleteQuery |