Re: Yet another fast GiST build (typo)

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Erik Rijkers <er(at)xs4all(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Yet another fast GiST build (typo)
Date: 2020-08-04 17:28:22
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> 30 июля 2020 г., в 06:26, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> написал(а):
> On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> Thanks! Fixed.
> It's not a bug, but I think those 64 bit constants should be wrapped
> in UINT64CONST(), following our convention.
Thanks, fixed!

> I'm confused about these two patches: 0001 introduces
> gist_point_fastcmp(), but then 0002 changes it to gist_bbox_fastcmp().
> Maybe you intended to keep both of them? Also 0002 seems to have
> fixups for 0001 squashed into it.
Indeed, that were fixups: point converted to GiST representation is a bbox already, and the function expects only bboxes.

Also I've fixed some mismerges in documentation.


Best regards, Andrey Borodin.

Attachment Content-Type Size
v10-0001-Add-sort-support-for-point-gist_point_sortsuppor.patch application/octet-stream 4.2 KB
v10-0002-Implement-GiST-build-using-sort-support.patch application/octet-stream 18.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2020-08-04 17:36:13 Re: Confusing behavior of create table like
Previous Message Konstantin Knizhnik 2020-08-04 17:21:18 Re: LSM tree for Postgres