| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add "format" target to make and ninja to run pgindent and pgperltidy |
| Date: | 2026-03-13 22:26:13 |
| Message-ID: | EAB73E05-6551-4537-A742-C091C9206B25@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 13 Mar 2026, at 16:11, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>
> On Fri, 13 Mar 2026 at 11:03, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> The primary reason thus far has been that pgperltidy requires a specific
>> version of perltidy, no other version is accepted. Imposing the burden of
>> installing that on a greater subset of people than a subset of committers
>> didn't seem palatable.
>
> I think that makes sense if the burden is big, but with patch 0008 it
> becomes as simple as running a single command:
> src/tools/pgindent/get_perltidy
In todays world of supply-chain attacks, don't think it's all that palatable to
take responsibility for installing code in peoples environments. Regardless, I
don't think the patch should remove the installation instructions.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-03-13 23:01:46 | Re: gistGetFakeLSN() can return incorrect LSNs |
| Previous Message | Heikki Linnakangas | 2026-03-13 21:57:38 | Re: [PATCH] Silence a new Valgrind warning |