| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Date: | 2021-10-03 17:04:19 |
| Message-ID: | E85855BD-C063-4B24-9EAA-02DECC8F42B9@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
> On Oct 2, 2021, at 10:32 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Sat, Oct 2, 2021 at 4:49 AM PG Bug reporting form
> <noreply(at)postgresql(dot)org> wrote:
>> Although you can add --exclude-relation=*.pg_temp*.*, this behaviour differs
>> from the behaviour of pg_dump and friends, which skip such relations
>> silently.
>
> I agree -- this behavior is a bug.
>
> Can you propose a fix, Mark?
The attached patch includes a test case for this, which shows the problems against the current pg_amcheck.c, and a new version of pg_amcheck.c which fixes the bug. Could you review it?
Thanks for bringing this to my attention.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Bug-fix-do-not-check-temp-tables-from-pg_amcheck.patch | application/octet-stream | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-03 17:22:48 | Re: BUG #16040: PL/PGSQL RETURN QUERY statement never uses a parallel plan |
| Previous Message | Tom Lane | 2021-10-03 03:48:06 | Re: BUG #16040: PL/PGSQL RETURN QUERY statement never uses a parallel plan |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-10-03 17:18:31 | ssl tests fail on windows / slurp_file() offset doesn't work on win |
| Previous Message | Simon Riggs | 2021-10-03 16:51:57 | Re: Reduce lock level for ALTER TABLE ... ADD CHECK .. NOT VALID |