Re: [HACKERS] Dbsize backend integration

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Robert Treat" <xzilla(at)users(dot)sourceforge(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Dawid Kuroczko" <qnex42(at)gmail(dot)com>, "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Dbsize backend integration
Date: 2005-07-04 18:54:26
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4AC8F93@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> -----Original Message-----
> From: Robert Treat [mailto:xzilla(at)users(dot)sourceforge(dot)net]
> Sent: 04 July 2005 18:21
> To: Dave Page
> Cc: Tom Lane; Dawid Kuroczko; Andreas Pflug; Bruce Momjian;
> PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [HACKERS] [PATCHES] Dbsize backend integration
>
>
> Actually I'd agree with Tom, pg_dbfile_size is ugly, and
> suggest to me I could
> use a filename as an argument.

I won't repeat Bruce's reply to you, but as an FYI, the reason Bruce
suggested pg_dbfile_size over the nicer pg_file_size is that our
instrumentation patch includes that particular function, which does
accept a filename (provided it's under $PGDATA or the log directory).
Dbfile was meant to indicate it's a database related file, rather than
some arbitrary filename.

/D

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim C. Nasby 2005-07-04 19:42:14 Re: HEAD doesn't cope with libraries in non-default locations
Previous Message Bruce Momjian 2005-07-04 17:25:41 Re: [HACKERS] Dbsize backend integration

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-07-04 18:57:07 Re: replace_text() improvement
Previous Message Bruce Momjian 2005-07-04 18:23:24 Fix zic compile