Re: programmers-readme.txt

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>, "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: programmers-readme.txt
Date: 2006-05-02 09:21:59
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4011CA057@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de]
> Sent: 30 April 2006 18:59
> To: Dave Page; pgadmin-hackers
> Subject: programmers-readme.txt
>
> Hm, I could have sworn that I already added
> programmers-readme.txt months ago to svn. Anyway, please
> review it if it makes sense to you.

Back at coding now, so...

With this, and the refactoring you've done in frmMain/events.cpp, the
factory stuff is infinitely easier to understand and no longer the
incomprehensible mess that it previously was ( :-p ) so yes, it does
make sense to me!

One thing I did notice - if using contextActionFactory, each item is
added to the context menu twice, the first copy of which doesn't work. A
basic actionFactory *does* add the item to the context menu correctly
though(!).

Regards, Dave.

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2006-05-02 09:23:50 Re: programmers-readme.txt
Previous Message Dave Page 2006-05-02 08:00:52 Re: Updated copy patch