Re: Odbcapi30.c - 64 bit compiler warning cleanup

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Ludek Finstrle" <luf(at)pzkagis(dot)cz>, <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Odbcapi30.c - 64 bit compiler warning cleanup
Date: 2006-01-26 17:07:12
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E40103DB6C@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

> -----Original Message-----
> From: pgsql-odbc-owner(at)postgresql(dot)org
> [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Dave Page
> Sent: 26 January 2006 16:54
> To: Tom Lane
> Cc: Ludek Finstrle; pgsql-odbc(at)postgresql(dot)org
> Subject: Re: [ODBC] Odbcapi30.c - 64 bit compiler warning cleanup
>
>
> > If so, I'd argue that that whole block (the "if (fOption == 30002 &&
> > vParam)" stuff) ought to be #ifdef WIN32. It's certainly useless on
> > any other platform,
>
> That's a good point - it didn't even cross my mind that that code is
> only useful on Windows. Thanks Tom!

And the resulting patch is attached, including the other 64 bit changes
that Luf & I have made already.

Luf, I think it's about time to apply the outstanding fixes and prepare
for a release. That OK with you?

Regards, Dave.

Attachment Content-Type Size
psqlodbc-64bit.diff application/octet-stream 17.1 KB

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Tom Lane 2006-01-26 17:16:54 Re: Odbcapi30.c - 64 bit compiler warning cleanup
Previous Message Dave Page 2006-01-26 16:53:38 Re: Odbcapi30.c - 64 bit compiler warning cleanup