Re: BUG #17268: Possible corruption in toast index after reindex index concurrently

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alexey Ermakov <alexey(dot)ermakov(at)dataegret(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Maxim Boguk <maxim(dot)boguk(at)gmail(dot)com>, "PostgreSQL mailing lists" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: BUG #17268: Possible corruption in toast index after reindex index concurrently
Date: 2021-12-08 04:29:35
Message-ID: E5481F15-E6D0-445C-94F1-8B4B9D40DA3D@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 12/7/21, 6:48 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> On Tue, Dec 07, 2021 at 10:04:54PM +0000, Bossart, Nathan wrote:
>> For example, could holding the locks longer impact performance?
>
> Do you have anything particular in mind? It seems to me that this
> boils down to the same lock taken on the parent table based on its
> RTE.

I don't have anything concrete in mind.

>> I think it would be good to expand the comments above these changes to
>> explain why we are keeping the lock. That might help avoid similar
>> problems in the future.
>
> Yes, I have added a note, and applied the patch after looking at it
> again this morning. The test cannot be used in 12 so I have removed
> it from REL_12_STABLE, as allow_system_table_mods is a PGC_POSTMASTER
> there.

Great!

Nathan

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message vignesh C 2021-12-08 04:32:15 Assertion failure during walsender exit
Previous Message PG Bug reporting form 2021-12-08 04:02:51 BUG #17326: Postgres crashed when pg_reload_conf() with ssl certificate parameters