| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bmomjian(at)gmail(dot)com> |
| Subject: | Re: Fix \crosstabview to honor \pset display_true/display_false |
| Date: | 2026-06-21 00:37:53 |
| Message-ID: | E25877D4-4A17-4A86-BA94-02DD742799BD@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jun 20, 2026, at 18:32, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Jun-19, David G. Johnston wrote:
>
>> Chao's decision to include the row and column headers makes more sense to
>> me. The promise of this feature is that the visual output of booleans as
>> t/f should go away if the user chooses to make use of these
>> local variables. While we may not be able get them all (e.g.,
>> composites and arrays) doing so here is trivial to accomplish.
>
> OK. TBH that part seemed a bit over the top to me, but that wasn't a
> very strongly held opinion. I'll put that back and push soonish.
>
> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
> "La gente vulgar sólo piensa en pasar el tiempo;
> el que tiene talento, en aprovecharlo"
Thank you both very much for reviewing and for the valuable comments.
I have made the helper private to crosstabview.c and left print.c unchanged in v3. I will see if I can improve print.h/c for v20.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Make-crosstabview-honor-boolean-display-settings.patch | application/octet-stream | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-06-21 06:39:11 | Re: Row pattern recognition |
| Previous Message | Andreas Karlsson | 2026-06-20 22:14:01 | Re: [PATCH] DOCS: Distinguish table and index storage parameters |