pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump.
Date: 2026-09-26 16:56:41
Message-ID: E1xAVhZ-00000001N3E-3M3r@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't emit garbage "\[un]restrict (null)" commands in pg_dump.

_reconnectToDB() failed to consider the possibility that it could
be called without any restrict_key set. This is reachable while
generating the "restore.sql" file in tar dump mode, which nobody
noticed because that file is mostly unused (and nothing really
bad happens anyway unless you specified --inserts mode). But
I wonder if there are other code paths that reach the issue.

Bug: #19718
Reported-by: Pavel Kopylov <pkopylov(at)cloudlinux(dot)com>
Author: Pavel Kopylov <pkopylov(at)cloudlinux(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b349762fdeb7193b55fd1ae44a2e79903f13b14a

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-09-27 21:55:38 pgsql: Enforce pg_class.relchecks limit (32,767 or INT16_MAX)
Previous Message Etsuro Fujita 2026-09-26 11:41:42 pgsql: postgres_fdw: Improve comment in fetch_remote_statistics().