| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix abort and launcher state resets in data checksums launcher |
| Date: | 2026-09-14 13:34:14 |
| Message-ID: | E1x66p4-00000000I6W-2uUU@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix abort and launcher state resets in data checksums launcher
The launcher_running flag was reset to false during shutdown, which
left a small window where a new launcher could be started when the
exit handler was still running. Fix by only updating the running
flag in shared memory in the exit handler if our local copy is true.
Also reset the aborted state if the launch_operation changes during
shutdown to allow scenarios like "start -> abort -> start" to work
even if they reach the second start before the abort is fully done.
Issues found by Noah and Robert using AI assisted review with Claude.
Backpatch to v19 where the online checksums feature was introduced.
Reported-by: Noah Misch <noah(at)leadboat(dot)com>
Reported-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Discussion: https://postgr.es/m/E15AC050-C4B5-488D-BB2D-3C7AC9F89EA8@yesql.se
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cffb4d8bd65e4c05ecd5697d09c4969467596ea5
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-09-14 14:16:41 | pgsql: Describe special values in more GUC descriptions. |
| Previous Message | Alexander Korotkov | 2026-09-14 11:50:05 | pgsql: Fix timeout overflow in WAIT FOR LSN |