| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve error message for checksum state in pg_upgrade |
| Date: | 2026-09-14 13:34:14 |
| Message-ID: | E1x66p4-00000000I6U-2pG9@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve error message for checksum state in pg_upgrade
When attempting to upgrade a cluster which is an inprogress state, the
same error message was used regardless of which state it was. Fix by
using different error messages for the different inprogress states.
Found by Noah using AI assisted review with Claude. Backpatch to v19
where the online checksums feature was introduced.
Reported-by: Noah Misch <noah(at)leadboat(dot)com>
Discussion: https://postgr.es/m/E15AC050-C4B5-488D-BB2D-3C7AC9F89EA8@yesql.se
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9a45131b7cf3b573d1b15a093a3cc80869814cbe
Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-09-14 14:16:41 | pgsql: Describe special values in more GUC descriptions. |
| Previous Message | Alexander Korotkov | 2026-09-14 11:50:05 | pgsql: Fix timeout overflow in WAIT FOR LSN |