| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove stale XXX comment in logical launcher |
| Date: | 2026-09-09 09:11:21 |
| Message-ID: | E1x4EKu-000000046w7-1mzh@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove stale XXX comment in logical launcher
An XXX comment in launcher.c added by commit 2af1dc89282b questioned why
the slot drop does not request disabling logical decoding. But the
conflict detection slot is a physical slot, so there is no logical
decoding state to disable. Remove that comment and clarify the
situation elsewhere.
Author: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Reviewed-by: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Backpatch-through: 19
Discussion: https://postgr.es/m/TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7beefa8d46978341aed7ba14cc82bf37c0564948
Modified Files
--------------
src/backend/replication/logical/launcher.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-09-09 10:58:47 | pgsql: Fix error message for concurrent repack on materialized views |
| Previous Message | Masahiko Sawada | 2026-09-08 20:06:23 | pgsql: Restrict REPACK (CONCURRENTLY) on user catalog tables. |