pgsql: Validate subscription conninfo on owner change

Validate subscription conninfo on owner change

For subscriptions using SERVER, changing the owner can change the
effective connection string. However, ALTER SUBSCRIPTION ... OWNER TO
did not validate the generated conninfo for the new owner.

As a result, ownership could be transferred to a non-superuser whose
generated connection string did not satisfy password_required=true.
The ownership change succeeded, but the subscription would fail later
when the worker or another command tried to connect.

Fix this by making ALTER SUBSCRIPTION ... OWNER TO validate the new
owner's generated conninfo with walrcv_check_conninfo().

Backpatch to v19, where SERVER subscriptions were introduced.

Author: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Reviewed-by: Yuanchao Zhang <145zhangyc(at)gmail(dot)com>
Reviewed-by: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Discussion: https://postgr.es/m/CAHGQGwFGa6+wWVgUmZPFwN=fBY59mYPkMK3=TxT=Pv5C1mNNRQ@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1c9c35890421e96a91129b51f2c6446a6d95af95

Modified Files
--------------
doc/src/sgml/ref/alter_subscription.sgml | 7 +++++++
src/backend/commands/subscriptioncmds.c | 14 ++++++++++++--
src/test/regress/expected/subscription.out | 17 +++++++++++++++++
src/test/regress/regress.c | 9 +++++++++
src/test/regress/sql/subscription.sql | 16 ++++++++++++++++
5 files changed, 61 insertions(+), 2 deletions(-)