pgsql: Minor cleanup around checking datachecksum worker result

Minor cleanup around checking datachecksum worker result

Rename the 'success' field in DataChecksumState to 'worker_result'.
That's more appropriate when it's not a simple boolean.

Don't access the field after releasing the lock in ProcessDatabase().
No other process should be modifying it, but if we bother to do any
locking in the first place, let's do it right.

Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://www.postgresql.org/message-id/b283fbb9-298e-4953-9120-eefaf24fae20@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c48e7b2c8bd09c3a81658ac2388be28b80b87142

Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 35 ++++++++++++++++-------------
1 file changed, 19 insertions(+), 16 deletions(-)