pgsql: read_stream: Move logic about IO combining & issuing to helpers

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: read_stream: Move logic about IO combining & issuing to helpers
Date: 2026-04-05 05:22:59
Message-ID: E1w9Fwo-0031cV-36@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

read_stream: Move logic about IO combining & issuing to helpers

The long if statements were hard to read and hard to document. Splitting them
into inline helpers makes it much easier to explain each part separately.

This is done in preparation for making the logic more complicated...

Reviewed-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Discussion: https://postgr.es/m/f3xxfrkafjxpyqxywcxricxgyizjirfceychyxsgn7bwjp5eda@kwbduhy7tfmu

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/434dab76ba76fba5dacab2dc695b6b3d5df8315b

Modified Files
--------------
src/backend/storage/aio/read_stream.c | 97 +++++++++++++++++++++++++++++------
1 file changed, 80 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2026-04-05 06:23:42 pgsql: aio: Simplify pgaio_worker_submit().
Previous Message John Naylor 2026-04-05 01:54:01 pgsql: Fix unused function warning on Arm platforms