| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add explanatory comment to prune_freeze_setup() |
| Date: | 2025-12-16 16:05:27 |
| Message-ID: | E1vVXYE-0015cE-0t@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add explanatory comment to prune_freeze_setup()
heap_page_prune_and_freeze() fills in PruneState->deadoffsets, the array
of OffsetNumbers of dead tuples. It is returned to the caller in the
PruneFreezeResult. To avoid having two copies of the array, the
PruneState saves only a pointer to the array. This was a bit unusual and
confusing, so add a clarifying comment.
Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Suggested-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAEoWx2=jiD1nqch4JQN+odAxZSD7mRvdoHUGJYN2r6tQG_66yQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bfe5c4bec75091d5c91813ff9c6994a169ceb8ef
Modified Files
--------------
src/backend/access/heap/pruneheap.c | 7 +++++++
1 file changed, 7 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-12-16 17:01:54 | pgsql: Test PRI* macros even when we can't test NLS translation. |
| Previous Message | Tomas Vondra | 2025-12-16 15:17:51 | Re: failed NUMA pages inquiry status: Operation not permitted |