pgsql: libpq-oauth: Don't translate internal errors

From: Jacob Champion <jchampion(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: libpq-oauth: Don't translate internal errors
Date: 2025-12-15 22:28:44
Message-ID: E1vVH3b-000yaW-27@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

libpq-oauth: Don't translate internal errors

Some error messages are generated when OAuth multiplexer operations fail
unexpectedly in the client. Álvaro pointed out that these are both
difficult to translate idiomatically (as they use internal terminology
heavily) and of dubious translation value to end users (since they're
going to need to get developer help anyway). The response parsing engine
has a similar issue.

Remove these from the translation files by introducing internal variants
of actx_error() and oauth_parse_set_error().

Suggested-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Reviewed-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Discussion: https://postgr.es/m/CAOYmi%2BkQQ8vpRcoSrA5EQ98Wa3G6jFj1yRHs6mh1V7ohkTC7JA%40mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/aac25567fec10b7b2cc382654e5586acebec5431

Modified Files
--------------
src/interfaces/libpq-oauth/oauth-curl.c | 85 +++++++++++++++++----------------
1 file changed, 45 insertions(+), 40 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-12-15 23:38:01 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
Previous Message Nathan Bossart 2025-12-15 20:28:19 pgsql: Allow passing a pointer to GetNamedDSMSegment()'s init callback.