pgsql: ci: Explicitly enable Meson features

From: Jacob Champion <jchampion(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: ci: Explicitly enable Meson features
Date: 2025-09-03 14:59:20
Message-ID: E1utoxE-000Jrg-31@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

ci: Explicitly enable Meson features

Meson's "auto" feature mode silently disables features with missing
prerequisites, which is nice for development but can lead to false
positives in the CI (such as my commit b0635bfda, which broke OAuth
detection on OpenBSD). Use an explicit feature list in the Cirrus config
instead; this mirrors the --with-XXX experience of Autoconf.

While we're here, also move common configuration options into a single
variable, MESON_COMMON_PG_CONFIG_ARGS, as suggested by Peter. The
resulting hierarchy is as follows:

MESON_COMMON_PG_CONFIG_ARGS "global" Meson configuration options

MESON_COMMON_FEATURES the default set of CI features, to be used
unless there's a specific reason not to

MESON_FEATURES per-OS feature configuration, overriding
the above

The current exceptions to the use of MESON_COMMON_FEATURES are
- SanityCheck, which uses almost no dependencies;
- Windows - VS, whose feature list has diverged significantly from the
others; and
- Linux, which continues to use 'auto' features so that autodetection is
still tested in the CI. (Options shared between 64- and 32-bit builds
can go into LINUX_MESON_FEATURES instead.)

Author: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Suggested-by: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Suggested-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/flat/CAN55FZ0aO8d_jkyRijcGP8qO%3DXH09qG%3Dpw0ZZDvB4LMzuXYU1w%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7b0fb9f5c68e7c7161a88b442f41b5345cd6cdd0

Modified Files
--------------
.cirrus.tasks.yml | 106 ++++++++++++++++++++++++++++++++++++++++++------------
1 file changed, 83 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-09-03 18:58:16 pgsql: Move dynamically-allocated LWLock tranche names to shared memory
Previous Message Zhijie Hou (Fujitsu) 2025-09-03 11:40:53 RE: pgsql: Preserve conflict-relevant data during logical replication.