pgsql: Avoid including tableam.h and xlogreader.h in nbtree.h

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid including tableam.h and xlogreader.h in nbtree.h
Date: 2025-08-14 15:50:40
Message-ID: E1umaDw-000XsW-1y@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid including tableam.h and xlogreader.h in nbtree.h

Doing that seems rather random and unnecessary. This commit removes
those and fixes fallout, which is pretty minimal. We do need to add a
forward declaration of struct TM_IndexDeleteOp (whose full definition
appears in tableam.h) so that _bt_delitems_delete_check()'s declaration
can use it.

Author: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Reviewed-by: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Discussion: https://postgr.es/m/202508051109.lzk3lcuzsaxo@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0e7e04ede165abc95ca16bd9fa93284cc4dac6d

Modified Files
--------------
contrib/btree_gist/btree_bool.c | 1 +
contrib/btree_gist/btree_cash.c | 1 +
contrib/btree_gist/btree_date.c | 1 +
contrib/btree_gist/btree_enum.c | 1 +
contrib/btree_gist/btree_float4.c | 1 +
contrib/btree_gist/btree_float8.c | 1 +
contrib/btree_gist/btree_inet.c | 1 +
contrib/btree_gist/btree_int2.c | 1 +
contrib/btree_gist/btree_int4.c | 1 +
contrib/btree_gist/btree_int8.c | 1 +
contrib/btree_gist/btree_interval.c | 1 +
contrib/btree_gist/btree_macaddr.c | 1 +
contrib/btree_gist/btree_macaddr8.c | 1 +
contrib/btree_gist/btree_oid.c | 1 +
contrib/btree_gist/btree_time.c | 1 +
contrib/btree_gist/btree_ts.c | 1 +
contrib/btree_gist/btree_utils_var.c | 1 +
contrib/btree_gist/btree_uuid.c | 1 +
src/backend/access/nbtree/nbtdedup.c | 1 +
src/backend/access/nbtree/nbtinsert.c | 1 +
src/backend/access/nbtree/nbtpreprocesskeys.c | 2 ++
src/backend/access/nbtree/nbtsort.c | 1 +
src/backend/access/nbtree/nbtsplitloc.c | 1 +
src/backend/access/nbtree/nbtutils.c | 3 +++
src/backend/utils/sort/tuplesortvariants.c | 1 +
src/include/access/nbtree.h | 6 +++---
26 files changed, 31 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-08-14 15:58:50 pgsql: ci: Per-repo configuration for manually trigger tasks
Previous Message Tom Lane 2025-08-14 15:39:23 pgsql: Don't leak memory during failure exit from SelectConfigFiles().