pgsql: Don't leak memory during failure exit from SelectConfigFiles().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't leak memory during failure exit from SelectConfigFiles().
Date: 2025-08-14 15:39:23
Message-ID: E1uma32-000XnQ-0N@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't leak memory during failure exit from SelectConfigFiles().

Make sure the memory allocated by make_absolute_path() is freed
when SelectConfigFiles() fails. Since all the callers will exit
immediately in that case, there's no practical gain here, but
silencing Valgrind leak complaints seems useful. In any case,
it was inconsistent that only one of the failure exits did this.

Author: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAJ7c6TMByXE8dc7zDvDWTQjk6o-XXAdRg_RAg5CBaUOgFPV3LQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ed0736172170bdae800b28e3555241b82854f09f

Modified Files
--------------
src/backend/utils/misc/guc.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-08-14 15:50:40 pgsql: Avoid including tableam.h and xlogreader.h in nbtree.h
Previous Message Heikki Linnakangas 2025-08-14 10:32:06 pgsql: Fix LSN format in debug message