pgsql: Add test of various escape functions

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add test of various escape functions
Date: 2025-02-10 15:09:48
Message-ID: E1thVPw-006Nxm-Ma@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add test of various escape functions

As highlighted by the prior commit, writing correct escape functions is less
trivial than one might hope.

This test module tries to verify that different escaping functions behave
reasonably. It e.g. tests:

- Invalidly encoded input to an escape function leads to invalidly encoded
output

- Trailing incomplete multi-byte characters are handled sensibly

- Escaped strings are parsed as single statement by psql's parser (which
derives from the backend parser)

There are further tests that would be good to add. But even in the current
state it was rather useful for writing the fix in the prior commit.

Reviewed-by: Noah Misch <noah(at)leadboat(dot)com>
Backpatch-through: 13
Security: CVE-2025-1094

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/02d4d87ac20e2698b5375b347c451c55045e388d

Modified Files
--------------
src/test/modules/Makefile | 1 +
src/test/modules/meson.build | 1 +
src/test/modules/test_escape/.gitignore | 2 +
src/test/modules/test_escape/Makefile | 27 +
src/test/modules/test_escape/meson.build | 31 +
src/test/modules/test_escape/t/001_test_escape.pl | 53 ++
src/test/modules/test_escape/test_escape.c | 803 ++++++++++++++++++++++
src/tools/pgindent/typedefs.list | 3 +
8 files changed, 921 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-02-10 15:09:49 pgsql: Add test of various escape functions
Previous Message Peter Eisentraut 2025-02-10 14:30:07 pgsql: Translation updates