| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add writeback to pg_stat_io |
| Date: | 2023-05-17 19:17:45 |
| Message-ID: | E1pzMeg-000NnN-0B@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add writeback to pg_stat_io
28e626bde00 added the concept of IOOps but neglected to include writeback
operations. ac8d53dae5 added time spent doing these I/O operations. Without
counting writeback, checkpointer write time in the log often differed
substantially from that in pg_stat_io. To fix this, add IOOp IOOP_WRITEBACK
and track writeback in pg_stat_io.
Bumps catversion.
Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Reported-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/20230419172326.dhgyo4wrrhulovt6%40awork3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/093e5c57d506783a95dd8feddd9a3f2651e1aeba
Modified Files
--------------
doc/src/sgml/monitoring.sgml | 26 ++++++++++++++++++++++++++
src/backend/catalog/system_views.sql | 2 ++
src/backend/storage/buffer/bufmgr.c | 32 +++++++++++++++++++++++++-------
src/backend/utils/activity/pgstat_io.c | 14 ++++++++------
src/backend/utils/adt/pgstatfuncs.c | 5 +++++
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 6 +++---
src/include/pgstat.h | 3 ++-
src/include/storage/buf_internals.h | 5 +++--
src/test/regress/expected/rules.out | 4 +++-
src/test/regress/expected/stats.out | 4 ++--
src/test/regress/sql/stats.sql | 4 ++--
12 files changed, 82 insertions(+), 25 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-05-17 19:38:48 | pgsql: Fix error message wordings |
| Previous Message | Alexander Korotkov | 2023-05-17 17:29:12 | pgsql: Revert "Add USER SET parameter values for pg_db_role_setting" |