| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. |
| Date: | 2023-03-31 14:08:51 |
| Message-ID: | E1piFQw-000f8k-K6@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Ensure acquire_inherited_sample_rows sets its output parameters.
The totalrows/totaldeadrows outputs were left uninitialized in cases
where we find no analyzable child tables of a partitioned table. This
could lead to setting the partitioned table's pg_class.reltuples value
to garbage. It's not clear that that would have any very bad effects
in practice, but fix it anyway because it's making valgrind unhappy.
Reported and diagnosed by Alexander Lakhin (bug #17880).
Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d0d92fe3d49934042f64539ccf2bb33c5f82158a
Modified Files
--------------
src/backend/commands/analyze.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-31 15:19:04 | pgsql: Reject system columns as elements of foreign keys. |
| Previous Message | Daniel Gustafsson | 2023-03-31 11:02:09 | pgsql: pg_regress: Emit TAP compliant output |