pgsql: Fix reading of BitString nodes

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix reading of BitString nodes
Date: 2022-09-24 22:29:27
Message-ID: E1ocDeJ-001rN3-0V@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix reading of BitString nodes

The node tokenizer went out of its way to store BitString node values
without the leading 'b'. But everything else in the system stores the
leading 'b'. This would break if a BitString node is
read-printed-read.

Also, the node tokenizer didn't know that BitString node tokens could
also start with 'x'.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/4159834(dot)1657405226(at)sss(dot)pgh(dot)pa(dot)us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2cb1a5a8d4aeb63da2d6a2d22169f05c60bb5828

Modified Files
--------------
src/backend/nodes/read.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-09-24 22:49:57 pgsql: Message style improvements
Previous Message Andres Freund 2022-09-24 20:51:30 pgsql: Remove uses of register due to incompatibility with C++17 and up