pgsql: Move any remaining files generated by pg_upgrade into an interna

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move any remaining files generated by pg_upgrade into an interna
Date: 2022-09-13 01:39:59
Message-ID: E1oXuu7-0005bU-55@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Move any remaining files generated by pg_upgrade into an internal subdir

This change concerns a couple of .txt files (for internal state checks)
that were still written in the path where the binary is executed, and
not in the subdirectory located in the target cluster. Like the other
.txt files doing already so (like loadable_libraries.txt), these are
saved in the base output directory. Note that on failure, the logs
report the full path to the .txt file generated, so these are easy to
find.

Oversight in 38bfae3.

Author: Daniel Gustafsson
Reviewed-by: Michael Paquier, Justin Prysby
Discussion: https://postgr.es/m/181A6DA8-3B7F-4B71-82D5-363FF0146820@yesql.se
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ee5353abb6124de5ffd24ef1cedbc2a7196d4fd5

Modified Files
--------------
src/bin/pg_upgrade/check.c | 12 +++++++++---
src/bin/pg_upgrade/version.c | 12 +++++++++---
2 files changed, 18 insertions(+), 6 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-09-13 01:52:19 pgsql: Rename macro related to pg_backup_stop()
Previous Message David Rowley 2022-09-12 23:05:40 pgsql: Don't reference out-of-bounds array elements in brin_minmax_mult

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-09-13 01:40:45 Re: pg_upgrade generated files in subdir follow-up
Previous Message Dilip Kumar 2022-09-13 01:30:42 Re: Error "initial slot snapshot too large" in create replication slot