pgsql: Replace many MemSet calls with struct initialization

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Replace many MemSet calls with struct initialization
Date: 2022-07-16 06:53:16
Message-ID: E1oCbfv-000RU7-TB@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Replace many MemSet calls with struct initialization

This replaces all MemSet() calls with struct initialization where that
is easily and obviously possible. (For example, some cases have to
worry about padding bits, so I left those.)

(The same could be done with appropriate memset() calls, but this
patch is part of an effort to phase out MemSet(), so it doesn't touch
memset() calls.)

Reviewed-by: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://www.postgresql.org/message-id/9847b13c-b785-f4e2-75c3-12ec77a3b05c@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9fd45870c1436b477264c0c82eb195df52bc0919

Modified Files
--------------
contrib/amcheck/verify_heapam.c | 6 +-
contrib/bloom/blcost.c | 4 +-
contrib/pageinspect/brinfuncs.c | 7 +-
contrib/pageinspect/hashfuncs.c | 16 +--
contrib/pageinspect/heapfuncs.c | 8 +-
contrib/pg_prewarm/autoprewarm.c | 6 +-
contrib/pg_stat_statements/pg_stat_statements.c | 7 +-
contrib/pg_visibility/pg_visibility.c | 15 +--
contrib/pg_walinspect/pg_walinspect.c | 25 ++--
contrib/pgstattuple/pgstatindex.c | 3 +-
contrib/postgres_fdw/connection.c | 7 +-
contrib/postgres_fdw/postgres_fdw.c | 3 +-
src/backend/access/transam/twophase.c | 6 +-
src/backend/access/transam/xlogfuncs.c | 7 +-
src/backend/catalog/aclchk.c | 146 +++++++-----------------
src/backend/catalog/dependency.c | 3 +-
src/backend/catalog/heap.c | 24 ++--
src/backend/catalog/index.c | 4 +-
src/backend/catalog/pg_attrdef.c | 9 +-
src/backend/catalog/pg_cast.c | 4 +-
src/backend/catalog/pg_parameter_acl.c | 6 +-
src/backend/catalog/pg_publication.c | 6 +-
src/backend/commands/dbcommands.c | 35 ++----
src/backend/commands/event_trigger.c | 11 +-
src/backend/commands/functioncmds.c | 7 +-
src/backend/commands/prepare.c | 4 +-
src/backend/commands/tablecmds.c | 44 +++----
src/backend/commands/tablespace.c | 4 +-
src/backend/commands/typecmds.c | 9 +-
src/backend/commands/user.c | 37 ++----
src/backend/optimizer/path/costsize.c | 3 +-
src/backend/parser/parse_target.c | 3 +-
src/backend/replication/logical/launcher.c | 7 +-
src/backend/replication/walsender.c | 17 +--
src/backend/rewrite/rewriteDefine.c | 8 +-
src/backend/utils/adt/acl.c | 4 +-
src/backend/utils/adt/arrayfuncs.c | 3 +-
src/backend/utils/adt/datetime.c | 8 +-
src/backend/utils/adt/lockfuncs.c | 12 +-
src/backend/utils/adt/partitionfuncs.c | 6 +-
src/backend/utils/adt/pgstatfuncs.c | 52 +++------
src/backend/utils/adt/selfuncs.c | 19 +--
src/backend/utils/adt/timestamp.c | 8 +-
src/backend/utils/mmgr/portalmem.c | 4 +-
src/bin/pg_basebackup/pg_basebackup.c | 13 +--
src/bin/pg_basebackup/pg_receivewal.c | 4 +-
src/bin/pg_basebackup/walmethods.c | 6 +-
src/common/ip.c | 4 +-
src/port/snprintf.c | 8 +-
src/test/modules/test_predtest/test_predtest.c | 3 +-
src/test/regress/regress.c | 3 +-
51 files changed, 200 insertions(+), 468 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Justin Pryzby 2022-07-16 11:37:52 Re: pgsql: Log details for client certificate failures
Previous Message Thomas Munro 2022-07-16 05:09:35 pgsql: Emulate sigprocmask(), not sigsetmask(), on Windows.