pgsql: Delete contrib/xml2's legacy implementation of xml_is_well_forme

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Delete contrib/xml2's legacy implementation of xml_is_well_forme
Date: 2022-02-14 15:56:27
Message-ID: E1nJdiF-00075W-EG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Delete contrib/xml2's legacy implementation of xml_is_well_formed().

This function is unreferenced in modern usage; it was superseded in 9.1
by a core function of the same name. It has been left in place in the C
code only so that pre-9.1 SQL definitions of the contrib/xml2 functions
would continue to work. Eleven years seems like enough time for people
to have updated to the extension-style version of the xml2 module, so
let's drop this.

We did this once before, in 20540710e, and then reverted it because
the intended change of PGDLLEXPORT markings didn't happen. This
time the reason is to suppress link-time duplicate-symbol warnings
on AIX. That's not worth a lot perhaps, but the value of keeping
this function has surely dropped to about zero by now.

Discussion: https://postgr.es/m/2717731.1644778752@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd2abeb7c2b285d0575eeb743744e3dca4f66323

Modified Files
--------------
contrib/xml2/xpath.c | 45 ---------------------------------------------
1 file changed, 45 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-02-14 16:25:53 pgsql: Suppress integer-overflow compiler warning for inconsistent sun_
Previous Message Fabien COELHO 2022-02-14 15:06:10 Re: pgsql: Track LLVM 15 changes.