pgsql: Change recently added test code for stability

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Change recently added test code for stability
Date: 2021-10-13 22:05:59
Message-ID: E1mamNr-0005HH-GG@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Change recently added test code for stability

The test code added with ff9f111bce24 fails under valgrind, and probably
other slow cases too, because if (say) autovacuum runs in between and
produces WAL of its own, the large INSERT fails to account for that in
the LSN calculations. Rewrite to use a DO loop.

Per complaint from Andres Freund

Backpatch to all branches.

Discussion: https://postgr.es/m/20211013180338.5guyqzpkcisqugrl@alap3.anarazel.de

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4b7abbe48a118e2b00f681e191da605e0d86b9c7

Modified Files
--------------
src/test/recovery/t/026_overwrite_contrecord.pl | 39 ++++++++++++++-----------
1 file changed, 22 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-10-14 03:14:20 Re: pgsql: Add more $Test::Builder::Level in the TAP tests
Previous Message Peter Geoghegan 2021-10-13 21:09:44 pgsql: pg_amcheck: avoid unhelpful verification attempts.