pgsql: Disable OpenSSL EVP digest padding in pgcrypto

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Disable OpenSSL EVP digest padding in pgcrypto
Date: 2021-09-25 09:48:30
Message-ID: E1mU4II-0003Bj-7T@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Disable OpenSSL EVP digest padding in pgcrypto

The PX layer in pgcrypto is handling digest padding on its own uniformly
for all backend implementations. Starting with OpenSSL 3.0.0, DecryptUpdate
doesn't flush the last block in case padding is enabled so explicitly
disable it as we don't use it.

This will be backpatched to all supported version once there is sufficient
testing in the buildfarm of OpenSSL 3.

Reviewed-by: Peter Eisentraut, Michael Paquier
Discussion: https://postgr.es/m/FEF81714-D479-4512-839B-C769D2605F8A@yesql.se
Backpatch-through: 9.6

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/00c72da4a22d9883b1e511ff140bd47cc75d536d

Modified Files
--------------
contrib/pgcrypto/openssl.c | 4 ++++
1 file changed, 4 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-09-25 09:48:42 pgsql: pgcrypto: Check for error return of px_cipher_decrypt()
Previous Message Daniel Gustafsson 2021-09-25 09:47:32 pgsql: Disable OpenSSL EVP digest padding in pgcrypto