pgsql: Remove pqsignal() from libpq's official exports list.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove pqsignal() from libpq's official exports list.
Date: 2018-09-28 16:38:17
Message-ID: E1g5vmT-0003K1-6S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Remove pqsignal() from libpq's official exports list.

Client applications should get this function, if they need it, from
libpgport.

The fact that it's exported from libpq is a hack left over from before
we set up libpgport. It's never been documented, and there's no good
reason for non-PG code to be calling it anyway, so hopefully this won't
cause any problems. Moreover, with the previous setup it was not real
clear whether our clients that use the function were getting it from
libpgport or libpq, so this might actually prevent problems.

The reason for changing it now is that in the wake of commit ea53100d5,
some linkers won't export the symbol, apparently because it's coming from
a .a library instead of a .o file. We could get around that by continuing
to symlink pqsignal.c into libpq as before; but unless somebody complains
very hard, I don't want to adopt such a kluge.

Discussion: https://postgr.es/m/13022.1538003440@sss.pgh.pa.us
Discussion: https://postgr.es/m/E1g5Y8r-0006vs-QA@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f7ab802855200df5529a6e1e7b748d7926acace8

Modified Files
--------------
src/interfaces/libpq/exports.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-09-28 18:28:30 pgsql: Build src/common files as a library with -fPIC.
Previous Message Tom Lane 2018-09-28 14:05:31 Re: pgsql: Build src/port files as a library with -fPIC, and use that in li

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-09-28 17:29:49 Re: SQL/JSON: documentation
Previous Message Alvaro Herrera 2018-09-28 15:49:46 Re: executor relation handling