pgsql: Improve pg_upgrade's status display

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve pg_upgrade's status display
Date: 2012-12-07 17:26:24
Message-ID: E1Th1gu-0007f0-Cd@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve pg_upgrade's status display

Pg_upgrade displays file names during copy and database names during
dump/restore. Andrew Dunstan identified three bugs:

* long file names were being truncated to 60 _leading_ characters, which
often do not change for long file names

* file names were truncated to 60 characters in log files

* carriage returns were being output to log files

This commit fixes these --- it prints 60 _trailing_ characters to the
status display, and full path names without carriage returns to log
files. It also suppresses status output to the log file unless verbose
mode is used.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6dd9584507199a6222ff2d6a40028bba69c9175e

Modified Files
--------------
contrib/pg_upgrade/dump.c | 2 +-
contrib/pg_upgrade/pg_upgrade.c | 2 +-
contrib/pg_upgrade/pg_upgrade.h | 4 +-
contrib/pg_upgrade/relfilenode.c | 2 +-
contrib/pg_upgrade/util.c | 40 +++++++++++++++++++++++--------------
5 files changed, 30 insertions(+), 20 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-12-08 12:48:21 pgsql: Update iso.org page link
Previous Message Simon Riggs 2012-12-07 14:24:17 Re: pgsql: Correct xmax test for COPY FREEZE