Skip site navigation (1) Skip section navigation (2)

pgsql: Fix intermittent crash in DROP INDEX CONCURRENTLY.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix intermittent crash in DROP INDEX CONCURRENTLY.
Date: 2012-12-06 04:43:12
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Fix intermittent crash in DROP INDEX CONCURRENTLY.

When deleteOneObject closes and reopens the pg_depend relation,
we must see to it that the relcache pointer held by the calling function
(typically performMultipleDeletions) is updated.  Usually the relcache
entry is retained so that the pointer value doesn't change, which is why
the problem had escaped notice ... but after a cache flush event there's
no guarantee that the same memory will be reassigned.  To fix, change
the recursive functions' APIs so that we pass around a "Relation *"
not just "Relation".

Per investigation of occasional buildfarm failures.  This is trivial
to reproduce with -DCLOBBER_CACHE_ALWAYS, which points up the sad
lack of any buildfarm member running that way on a regular basis.



Modified Files
src/backend/catalog/dependency.c |   36 ++++++++++++++++++------------------
1 files changed, 18 insertions(+), 18 deletions(-)

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2012-12-06 21:02:11
Subject: pgsql: Background worker processes
Previous:From: Alvaro HerreraDate: 2012-12-06 02:11:39
Subject: pgsql: Update comment at top of index_create

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group