pgsql: Produce a more useful error message for over-length Unix socket

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Produce a more useful error message for over-length Unix socket
Date: 2012-11-30 00:58:17
Message-ID: E1TeEvp-00045U-4T@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Produce a more useful error message for over-length Unix socket paths.

The length of a socket path name is constrained by the size of struct
sockaddr_un, and there's not a lot we can do about it since that is a
kernel API. However, it would be a good thing if we produced an
intelligible error message when the user specifies a socket path that's too
long --- and getaddrinfo's standard API is too impoverished to do this in
the natural way. So insert explicit tests at the places where we construct
a socket path name. Now you'll get an error that makes sense and even
tells you what the limit is, rather than something generic like
"Non-recoverable failure in name resolution".

Per trouble report from Jeremy Drake and a fix idea from Andrew Dunstan.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4af446e7cd0b37bb5d7fa9b73193c68e14239499

Modified Files
--------------
src/backend/libpq/pqcomm.c | 8 ++++++++
src/include/libpq/pqcomm.h | 13 +++++++++++++
src/interfaces/libpq/fe-connect.c | 11 ++++++++++-
3 files changed, 31 insertions(+), 1 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2012-11-30 06:19:09 pgsql: Add libpq function PQconninfo()
Previous Message Tom Lane 2012-11-30 00:32:31 Re: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)