Skip site navigation (1) Skip section navigation (2)

pgsql: Avoid bogus "out-of-sequence timeline ID" errors instandby-mode

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid bogus "out-of-sequence timeline ID" errors instandby-mode
Date: 2012-11-22 16:20:41
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Avoid bogus "out-of-sequence timeline ID" errors in standby-mode.

When startup process opens a WAL segment after replaying part of it, it
validates the first page on the WAL segment, even though the page it's
really interested in later in the file. As part of the validation, it checks
that the TLI on the page header is >= the TLI it saw on the last page it
read. If the segment contains a timeline switch, and we have already
replayed it, and then re-open the WAL segment (because of streaming
replication got disconnected and reconnected, for example), the TLI check
will fail when the first page is validated. Fix that by relaxing the TLI
check when re-opening a WAL segment.

Backpatch to 9.0. Earlier versions had the same code, but before standby
mode was introduced in 9.0, recovery never tried to re-read a segment after
partially replaying it.

Reported by Amit Kapila, while testing a new feature.



Modified Files
src/backend/access/transam/xlog.c |   32 +++++++++++++++++++++++---------
1 files changed, 23 insertions(+), 9 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2012-11-22 16:25:24
Subject: pgsql: Fix pg_resetxlog to use correct path to
Previous:From: Tom LaneDate: 2012-11-21 20:19:44
Subject: pgsql: Don't launch new child processes after we've been told to shutd

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group