pgsql: Fix race condition in pg_ctl reading postmaster.pid.

Fix race condition in pg_ctl reading postmaster.pid.

If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl
could overrun the buffer it allocated for the file. Fix by reading the
whole file to memory with one read() call.

initdb contains an identical copy of the readfile() function, but the files
that initdb reads are static, not modified concurrently. Nevertheless, add
a simple bounds-check there, if only to silence static analysis tools.

Per report from Dave Vitek. Backpatch to all supported branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5c89684e08cda82727bd8bdad155b9235fb7246e

Modified Files
--------------
src/bin/initdb/initdb.c | 9 +++--
src/bin/pg_ctl/pg_ctl.c | 88 +++++++++++++++++++++++++++++++----------------
2 files changed, 63 insertions(+), 34 deletions(-)