pgsql: Fix line end mishandling in pg_upgrade on Windows.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix line end mishandling in pg_upgrade on Windows.
Date: 2012-09-05 21:51:10
Message-ID: E1T9NV7-0000dq-WD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f7b13e48375a5a8ea2a8b157622a9310512f4e27

Modified Files
--------------
contrib/pg_upgrade/dump.c | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2012-09-05 22:00:54 pgsql: Fix pg_upgrade test script's line end handling on Windows.
Previous Message Andrew Dunstan 2012-09-05 21:51:01 pgsql: Fix line end mishandling in pg_upgrade on Windows.