Skip site navigation (1) Skip section navigation (2)

pgsql: Perform conversion from Python unicode to string/bytes objectvi

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Perform conversion from Python unicode to string/bytes objectvi
Date: 2012-08-06 11:34:09
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Perform conversion from Python unicode to string/bytes object via UTF-8.

We used to convert the unicode object directly to a string in the server
encoding by calling Python's PyUnicode_AsEncodedString function. In other
words, we used Python's routines to do the encoding. However, that has a
few problems. First of all, it required keeping a mapping table of Python
encoding names and PostgreSQL encodings. But the real killer was that Python
doesn't support EUC_TW and MULE_INTERNAL encodings at all.

Instead, convert the Python unicode object to UTF-8, and use PostgreSQL's
encoding conversion functions to convert from UTF-8 to server encoding. We
were already doing the same in the other direction in PLyUnicode_FromString,
so this is more consistent, too.

Note: This makes SQL_ASCII to behave more leniently. We used to map
SQL_ASCII to Python's 'ascii', which on Python means strict 7-bit ASCII
only, so you got an error if the python string contained anything but pure
ASCII. You no longer get an error; you get the UTF-8 representation of the
string instead.

Backpatch to 9.0, where these conversions were introduced.

Jan UrbaƄski



Modified Files
src/pl/plpython/expected/plpython_unicode_3.out |   54 -------------
src/pl/plpython/plpython.c                      |   98 ++++++++++-------------
2 files changed, 44 insertions(+), 108 deletions(-)

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2012-08-06 11:59:43
Subject: Re: Re: [COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.
Previous:From: Bruce MomjianDate: 2012-08-05 03:26:51
Subject: Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group