Skip site navigation (1) Skip section navigation (2)

pgsql: connoinherit may be true only for CHECK constraints

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: connoinherit may be true only for CHECK constraints
Date: 2012-07-20 18:10:53
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
connoinherit may be true only for CHECK constraints

The code was setting it true for other constraints, which is
bogus.  Doing so caused bogus catalog entries for such constraints, and
in particular caused an error to be raised when trying to drop a
constraint of types other than CHECK from a table that has children,
such as reported in bug #6712.

In 9.2, additionally ignore connoinherit=true for other constraint
types, to avoid having to force initdb; existing databases might already
contain bogus catalog entries.

Includes a catversion bump (in HEAD only).

Bug report from Miroslav Ć ulc
Analysis from Amit Kapila and Noah Misch; Amit also contributed the patch.



Modified Files
src/backend/catalog/index.c           |    2 +-
src/backend/commands/tablecmds.c      |    2 +-
src/backend/commands/trigger.c        |    2 +-
src/include/catalog/catversion.h      |    2 +-
src/test/regress/expected/inherit.out |  117 +++++++++++++++++++++++++++++++++
src/test/regress/sql/inherit.sql      |   36 ++++++++++
6 files changed, 157 insertions(+), 4 deletions(-)

pgsql-committers by date

Next:From: Peter EisentrautDate: 2012-07-20 19:35:52
Subject: pgsql: pg_dump: Simplify mkdir() error checking
Previous:From: Tom LaneDate: 2012-07-20 17:11:24
Subject: pgsql: Fix whole-row Var evaluation to cope with resjunk columns(again

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group