pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding
Date: 2012-07-10 19:46:55
Message-ID: E1SogOd-0002HH-7t@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

plperl: Skip setting UTF8 flag when in SQL_ASCII encoding

When in SQL_ASCII encoding, strings passed around are not necessarily
UTF8-safe. We had already fixed this in some places, but it looks like
we missed some.

I had to backpatch Peter Eisentraut's a8b92b60 to 9.1 in order for this
patch to cherry-pick more cleanly.

Patch from Alex Hunsaker, tweaked by Kyotaro HORIGUCHI and myself.

Some desultory cleanup and comment addition by me, during patch review.

Per bug report from Christoph Berg in
20120209102116(dot)GA14429(at)msgid(dot)df7cb(dot)de

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/379607c9e83dcfaccf6ccda47615e7f90c3c0b0c

Modified Files
--------------
src/pl/plperl/GNUmakefile | 2 +-
src/pl/plperl/Util.xs | 27 ++++++++++----
src/pl/plperl/expected/plperl.out | 10 -----
src/pl/plperl/expected/plperl_lc.out | 33 +++++++++++++++++
src/pl/plperl/expected/plperl_lc_1.out | 41 +++++++++++++++++++++
src/pl/plperl/plperl_helpers.h | 61 +++++++++++++++++++++++--------
src/pl/plperl/sql/plperl.sql | 9 -----
src/pl/plperl/sql/plperl_lc.sql | 24 ++++++++++++
8 files changed, 163 insertions(+), 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2012-07-10 19:53:18 pgsql: PL/Perl: Avoid compiler warning from clang
Previous Message Tom Lane 2012-07-10 18:54:54 pgsql: Re-implement extraction of fixed prefixes from regular expressio