pgsql: Unify calling conventions for postgres/postmaster sub-main funct

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Unify calling conventions for postgres/postmaster sub-main funct
Date: 2012-06-25 18:32:38
Message-ID: E1SjE5W-00065E-J1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Unify calling conventions for postgres/postmaster sub-main functions

There was a wild mix of calling conventions: Some were declared to
return void and didn't return, some returned an int exit code, some
claimed to return an exit code, which the callers checked, but
actually never returned, and so on.

Now all of these functions are declared to return void and decorated
with attribute noreturn and don't return. That's easiest, and most
code already worked that way.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/eeece9e60984e76e5a41c1e2fa9efc5a1761e560

Modified Files
--------------
src/backend/main/main.c | 17 +++++++-------
src/backend/postmaster/autovacuum.c | 4 +-
src/backend/postmaster/pgarch.c | 2 +-
src/backend/postmaster/pgstat.c | 2 +-
src/backend/postmaster/postmaster.c | 38 +++++++++++++-------------------
src/backend/postmaster/syslogger.c | 1 +
src/backend/replication/walsender.c | 10 ++++----
src/backend/tcop/postgres.c | 9 +++++--
src/backend/utils/misc/help_config.c | 4 +-
src/include/bootstrap/bootstrap.h | 2 +-
src/include/pgstat.h | 2 +-
src/include/postmaster/autovacuum.h | 4 +-
src/include/postmaster/bgwriter.h | 4 +-
src/include/postmaster/pgarch.h | 2 +-
src/include/postmaster/postmaster.h | 4 +-
src/include/postmaster/startup.h | 2 +-
src/include/postmaster/syslogger.h | 2 +-
src/include/postmaster/walwriter.h | 2 +-
src/include/replication/walreceiver.h | 2 +-
src/include/replication/walsender.h | 2 +-
src/include/storage/ipc.h | 2 +-
src/include/tcop/tcopprot.h | 4 +-
src/include/utils/help_config.h | 2 +-
23 files changed, 60 insertions(+), 63 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2012-06-25 22:45:44 pgsql: Tighten up includes in sinvaladt.h, twophase.h, proc.h
Previous Message Robert Haas 2012-06-25 18:00:57 pgsql: Fix typo in DEBUG message, introduced by recent WAL refactoring.