pgsql: Fix misleading output from gin_desc().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix misleading output from gin_desc().
Date: 2012-04-06 22:11:03
Message-ID: E1SGHN1-0008TK-Il@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix misleading output from gin_desc().

XLOG_GIN_UPDATE_META_PAGE and XLOG_GIN_DELETE_LISTPAGE records were printed
with a list link field labeled as "blkno", which was confusing, especially
when the link was empty (InvalidBlockNumber). Print the metapage block
number instead, since that's what's actually being updated. We could
include the link values too as a separate field, but not clear it's worth
the trouble.

Back-patch to 8.4 where the dubious code was added.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0ab4db52c0d45763adee3981da4325e7c353e443

Modified Files
--------------
src/backend/access/gin/ginxlog.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-04-06 23:00:52 pgsql: Update URL for pgtclng project.
Previous Message Tom Lane 2012-04-06 20:59:03 pgsql: Fix broken comparetup_datum code.