pgsql: Remove useless PGRES_COPY_BOTH "support" in psql.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove useless PGRES_COPY_BOTH "support" in psql.
Date: 2012-04-04 20:15:31
Message-ID: E1SFWc7-0002da-3F@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove useless PGRES_COPY_BOTH "support" in psql.

There is no existing or foreseeable case in which psql should see a
PGRES_COPY_BOTH PQresultStatus; and if such a case ever emerges, it's a
pretty good bet that these code fragments wouldn't do the right thing
anyway. Remove them, and let the existing default cases do the appropriate
thing, namely emit an "unexpected PQresultStatus" bleat.

Noted while working on libpq row processor patch, for which I was
considering adding a PGRES_SUSPENDED status code --- the same default-case
treatment would be appropriate for that.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cb917e1544612c187c74fed1a990e26820514c8a

Modified Files
--------------
src/bin/psql/common.c | 24 +++++-------------------
1 files changed, 5 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-04-04 22:40:37 pgsql: Add a "row processor" API to libpq for better handling of large
Previous Message Tom Lane 2012-04-04 19:06:32 pgsql: Fix syslogger to not lose log coherency under high load.