Skip site navigation (1) Skip section navigation (2)

pgsql: Remove useless PGRES_COPY_BOTH "support" in psql.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove useless PGRES_COPY_BOTH "support" in psql.
Date: 2012-04-04 20:15:31
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Remove useless PGRES_COPY_BOTH "support" in psql.

There is no existing or foreseeable case in which psql should see a
PGRES_COPY_BOTH PQresultStatus; and if such a case ever emerges, it's a
pretty good bet that these code fragments wouldn't do the right thing
anyway.  Remove them, and let the existing default cases do the appropriate
thing, namely emit an "unexpected PQresultStatus" bleat.

Noted while working on libpq row processor patch, for which I was
considering adding a PGRES_SUSPENDED status code --- the same default-case
treatment would be appropriate for that.



Modified Files
src/bin/psql/common.c |   24 +++++-------------------
1 files changed, 5 insertions(+), 19 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2012-04-04 22:40:37
Subject: pgsql: Improve efficiency of dblink by using libpq's new rowprocessor
Previous:From: Tom LaneDate: 2012-04-04 19:06:32
Subject: pgsql: Fix syslogger to not lose log coherency under high load.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group