Skip site navigation (1) Skip section navigation (2)

pgsql: Revise FDW planning API, again.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revise FDW planning API, again.
Date: 2012-03-09 17:49:42
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Revise FDW planning API, again.

Further reflection shows that a single callback isn't very workable if we
desire to let FDWs generate multiple Paths, because that forces the FDW to
do all work necessary to generate a valid Plan node for each Path.  Instead
split the former PlanForeignScan API into three steps: GetForeignRelSize,
GetForeignPaths, GetForeignPlan.  We had already bit the bullet of breaking
the 9.1 FDW API for 9.2, so this shouldn't cause very much additional pain,
and it's substantially more flexible for complex FDWs.

Add an fdw_private field to RelOptInfo so that the new functions can save
state there rather than possibly having to recalculate information two or
three times.

In addition, we'd not thought through what would be needed to allow an FDW
to set up subexpressions of its choice for runtime execution.  We could
treat ForeignScan.fdw_private as an executable expression but that seems
likely to break existing FDWs unnecessarily (in particular, it would
restrict the set of node types allowable in fdw_private to those supported
by expression_tree_walker).  Instead, invent a separate field fdw_exprs
which will receive the postprocessing appropriate for expression trees.
(One field is enough since it can be a list of expressions; also, we assume
the corresponding expression state tree(s) will be held within fdw_state,
so we don't need to add anything to ForeignScanState.)

Per review of Hanada Shigeru's pgsql_fdw patch.  We may need to tweak this
further as we continue to work on that patch, but to me it feels a lot
closer to being right now.



Modified Files
contrib/file_fdw/file_fdw.c             |  161 +++++++++++++++++-----
doc/src/sgml/fdwhandler.sgml            |  230 ++++++++++++++++++++++++++-----
src/backend/nodes/copyfuncs.c           |    3 +-
src/backend/nodes/outfuncs.c            |    4 +-
src/backend/optimizer/path/allpaths.c   |   13 +-
src/backend/optimizer/path/costsize.c   |    2 +-
src/backend/optimizer/plan/createplan.c |   67 ++++++---
src/backend/optimizer/plan/setrefs.c    |    2 +
src/backend/optimizer/plan/subselect.c  |    2 +
src/backend/optimizer/util/pathnode.c   |    2 +-
src/backend/optimizer/util/relnode.c    |    4 +
src/include/foreign/fdwapi.h            |   21 +++-
src/include/nodes/plannodes.h           |   11 ++-
src/include/nodes/relation.h            |   24 ++--
src/include/optimizer/planmain.h        |    2 +
15 files changed, 436 insertions(+), 112 deletions(-)

pgsql-committers by date

Next:From: Robert HaasDate: 2012-03-09 19:40:34
Subject: pgsql: Extend object access hook framework to support arguments,and DR
Previous:From: Heikki LinnakangasDate: 2012-03-09 06:09:13
Subject: pgsql: Update outdated comment. HeapTupleHeader.t_natts field doesn'te

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group