Remove extra copies of LogwrtResult.
This simplifies the code a little bit. The new rule is that to update
XLogCtl->LogwrtResult, you must hold both WALWriteLock and info_lck, whereas
before we had two copies, one that was protected by WALWriteLock and another
protected by info_lck. The code that updates them was already holding both
locks, so merging the two is trivial.
The third copy, XLogCtl->Insert.LogwrtResult, was not totally redundant, it
was used in AdvanceXLInsertBuffer to update the backend-local copy, before
acquiring the info_lck to read the up-to-date value. But the value of that
seems dubious; at best it's saving one spinlock acquisition per completed
WAL page, which is not significant compared to all the other work involved.
And in practice, it's probably not saving even that much.
src/backend/access/transam/xlog.c | 74 +++++++++++--------------------------
1 files changed, 22 insertions(+), 52 deletions(-)
pgsql-hackers by date
|Next:||From: Simon Riggs||Date: 2012-03-06 08:44:38|
|Subject: Re: Checksums, state of play|
|Previous:||From: Marko Kreen||Date: 2012-03-06 08:13:31|
|Subject: Re: Speed dblink using alternate libpq tuple storage|
pgsql-committers by date
|Next:||From: Heikki Linnakangas||Date: 2012-03-06 08:47:34|
|Subject: pgsql: Make the comments more clear on the fact thatUpdateFullPageWrit|
|Previous:||From: Bruce Momjian||Date: 2012-03-06 02:20:08|
|Subject: pgsql: In pg_upgrade, only lock the old cluster if link mode is used,a|