pgsql: Remove useless "rough estimate" path from mcelem_array_contained

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove useless "rough estimate" path from mcelem_array_contained
Date: 2012-03-04 21:03:47
Message-ID: E1S4Iap-0002XE-Ud@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove useless "rough estimate" path from mcelem_array_contained_selec.

The code in this function that tried to cope with a missing count histogram
was quite ineffective for anything except a perfectly flat distribution.
Furthermore, since we were already punting for missing MCELEM slot, it's
rather useless to sweat over missing DECHIST: there are no cases where
ANALYZE will create the first but not the second. So just simplify the
code by punting rather than pretending we can do something useful.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e2eed7891008cbf2b7d3868b3d77751b33ed09ad

Modified Files
--------------
src/backend/utils/adt/array_selfuncs.c | 138 ++++++++++++++-----------------
1 files changed, 62 insertions(+), 76 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-03-05 03:50:18 pgsql: Rewrite GiST support code for rangetypes.
Previous Message Tom Lane 2012-03-04 20:40:44 pgsql: Improve histogram-filling loop in new compute_array_stats() code