Skip site navigation (1) Skip section navigation (2)

pgsql: Further repair of eqjoinsel ndistinct-clamping logic.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Further repair of eqjoinsel ndistinct-clamping logic.
Date: 2011-09-01 04:20:31
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Further repair of eqjoinsel ndistinct-clamping logic.

Examination of examples provided by Mark Kirkwood and others has convinced
me that actually commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 was quite
a few bricks shy of a load.  The useful part of that patch was clamping
ndistinct for the inner side of a semi or anti join, and the reason why
that's needed is that it's the only way that restriction clauses
eliminating rows from the inner relation can affect the estimated size of
the join result.  I had not clearly understood why the clamping was
appropriate, and so mis-extrapolated to conclude that we should clamp
ndistinct for the outer side too, as well as for both sides of regular
joins.  These latter actions were all wrong, and are reverted with this
patch.  In addition, the clamping logic is now made to affect the behavior
of both paths in eqjoinsel_semi, with or without MCV lists to compare.
When we have MCVs, we suppose that the most common values are the ones
that are most likely to survive the decimation resulting from a lower
restriction clause, so we think of the clamping as eliminating non-MCV
values, or potentially even the least-common MCVs for the inner relation.

Back-patch to 8.4, same as previous fixes in this area.



Modified Files
src/backend/utils/adt/selfuncs.c |  108 +++++++++++++++++--------------------
1 files changed, 50 insertions(+), 58 deletions(-)

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2011-09-01 06:37:13
Subject: pgsql: Move the line to undefine setlocale() macro on Win32 outsideUSE
Previous:From: Tom LaneDate: 2011-09-01 03:15:21
Subject: Re: pgsql: Allow more include files to be compiled in their own by adding m

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group