pgsql: In initialize_SSL, don't fail unnecessarily when home dir is una

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In initialize_SSL, don't fail unnecessarily when home dir is una
Date: 2011-03-04 16:40:00
Message-ID: E1PvY2q-0000Zt-SX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In initialize_SSL, don't fail unnecessarily when home dir is unavailable.

Instead, just act as though the certificate file(s) are not present.
There is only one case where this need be a hard failure condition: when
sslmode is verify-ca or verify-full, not having a root cert file is an
error. Change the logic so that we complain only in that case, and
otherwise fall through cleanly. This is how it used to behave pre-9.0,
but my patch 4ed4b6c54e5fab24ab2624d80e26f7546edc88ad of 2010-05-26 broke
the case. Per report from Christian Kastner.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bd58d9d883111ee84de4af480ebb018fe9b0bf27

Modified Files
--------------
src/interfaces/libpq/fe-secure.c | 64 ++++++++++++++++++++++++-------------
1 files changed, 41 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-03-04 20:16:08 pgsql: When creating a collation, check that the locales can be loaded
Previous Message Heikki Linnakangas 2011-03-04 13:51:14 pgsql: You must hold a lock on the heap page when you call